Skip to content

perf(c++): fair benchmark for cpp #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pandalee99 merged 4 commits into from
Dec 2, 2025
Merged

perf(c++): fair benchmark for cpp #2963

pandalee99 merged 4 commits into from
Dec 2, 2025

Conversation

@chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Dec 2, 2025 •
edited
Loading

Why?

The previouse benchmark is not fair:

  • Protobuf encode negative varint use 5 bytes, but fory may only use one bytes. And for small varint, fory has zigzag cost. this is not a fair compare
  • When serialize Sample, Fory allocate a vector every time, but protobuf serialize to a buffer instead.

What does this PR do?

  • Make NumericStruct contains int32 of all kinds size, and positive and negative
  • Make fory serialize to a buffer to for sample

With this fair compare, fory is similair performance as protobuf

Related issues

#2958
#2960

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

Datatype Operation Fory (ns) Protobuf (ns) Faster
Sample Serialize 345.6 316.4 Protobuf (1.1x)
Sample Deserialize 1376.4 1374.6 Protobuf (1.0x)
Struct Serialize 129.4 157.0 Fory (1.2x)
Struct Deserialize 207.5 154.4 Protobuf (1.3x)

@chaokunyang chaokunyang mentioned this pull request Dec 2, 2025
Merged
2 tasks
@pandalee99 pandalee99 merged commit 313fc71 into apache:main Dec 2, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pandalee99 pandalee99 pandalee99 approved these changes

@theweipeng theweipeng Awaiting requested review from theweipeng

@urlyy urlyy Awaiting requested review from urlyy

@LiangliangSui LiangliangSui Awaiting requested review from LiangliangSui

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chaokunyang @pandalee99