feat(Rust): support Option in MetaFieldType se/de #2528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Rust does not support objects being
null; instead, it uses theOptiontype to wrap nullable objects. In the current Rust macros,Option<T>is extracted asMetaFieldType { name: "Option", generics: [T] }, and then compared with theMetaFieldType { name: T, generics: [] }received from the sender peer like java. This causes a type mismatch. Therefore, theOptiontype requires special handling.What does this PR do?
Optionin MetaFieldType se/de. Specifically, during Rust peer serialization, I will serializeOption<T>as(T::type_id, nullable=true). During deserialization,(T::type_id, nullable=true)will be converted toOption<T>, while(T::type_id, nullable=false)will be converted toT.FieldIdtoTypeId.notice
It doesn’t support handling adjacent Options, such as Option<Option>.
Related issues
#2526
Does this PR introduce any user-facing change?
Benchmark