Skip to content

feat(java): optimize string serialization by concating coder and length #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaokunyang merged 14 commits into from
Apr 12, 2024
Merged

feat(java): optimize string serialization by concating coder and length #1486

chaokunyang merged 14 commits into from
Apr 12, 2024

Conversation

@chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Apr 10, 2024 •
edited
Loading

What does this PR do?

This PR optimize string serialization by concating coder and length into a long and serialize it together, it can save one byte for small string which the length is less than 32

Related issues

#1240

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

Before

Benchmark                                  (bufferType)   (objectType)  (references)   Mode  Cnt        Score       Error  Units
UserTypeDeserializeSuite.fury_deserialize         array  MEDIA_CONTENT         false  thrpt   50  2576580.395 ± 55698.851  ops/s

This PR:

Benchmark                                  (bufferType)   (objectType)  (references)   Mode  Cnt        Score       Error  Units
UserTypeDeserializeSuite.fury_deserialize         array  MEDIA_CONTENT         false  thrpt   50  2591695.102 ± 48174.940  ops/s

@chaokunyang chaokunyang marked this pull request as draft April 10, 2024 06:23
@chaokunyang chaokunyang marked this pull request as ready for review April 11, 2024 14:04
@chaokunyang
Copy link
Collaborator Author

chaokunyang commented Apr 11, 2024

@theweipeng @LiangliangSui Could you please help review this PR?

@chaokunyang chaokunyang merged commit 46db7e0 into apache:main Apr 12, 2024
@chaokunyang chaokunyang mentioned this pull request Apr 12, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theweipeng theweipeng theweipeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chaokunyang @theweipeng