[spark] Add scan.maxRecordsPerPartition config to split log table input partitions#3260
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
@luoyuxia @fresh-borzoni PTAL! |
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@Yohahaha Ty for the PR, overall LGTM, left minor comments, PTAL
75e67cc to
4bc7805
Compare
Contributor
Author
|
@luoyuxia @YannByron more comments? |
YannByron
reviewed
May 15, 2026
YannByron
reviewed
May 15, 2026
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@Yohahaha Ty for the changes, LGTM 👍 , just minor comment
Member
|
@Yohahaha you need to update config key in tests to fix tests |
d1a698b to
72ee21e
Compare
Contributor
Author
|
@luoyuxia PTAL! |
YannByron
approved these changes
Jun 1, 2026
72ee21e to
a1ad761
Compare
a1ad761 to
e9082dc
Compare
fresh-borzoni
approved these changes
Jun 2, 2026
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@Yohahaha Ty for the change, LGTM overall, couple of comments, PTAL
| startOffset: Long, | ||
| stopOffset: Long, | ||
| maxRecords: Long): Seq[InputPartition] = { | ||
| if ( |
Member
There was a problem hiding this comment.
what about empty tables and buckets?
Contributor
Author
|
@fresh-borzoni Sorry, I've been busy with other higher priority stuff lately, so I didn't get a chance to address the PR comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3215
Brief change log
scan.maxRecordsPerPartitionconfig option for Spark log table reads. When set, each Flussbucket whose offset range exceeds this value will be split into multiple Spark input partitions, improving
read parallelism for large offset ranges.
BucketOffsetsRetrieverImplto support fetching real earliest offsets when needed.Tests
SparkLogTableReadTest: "Spark Read: split partition by config"API and Format
Documentation