Fix IndexOutOfBoundsException in ArrowArrayWriter when element count exceeds INITIAL_CAPACITY#2287
Closed
platinumhamburg wants to merge 1 commit into
Closed
Fix IndexOutOfBoundsException in ArrowArrayWriter when element count exceeds INITIAL_CAPACITY#2287platinumhamburg wants to merge 1 commit into
platinumhamburg wants to merge 1 commit into
Conversation
…lement count exceeds INITIAL_CAPACITY Root cause: ArrowArrayWriter incorrectly used parent row's handleSafe flag (based on row count) for element writers, while element indices are based on cumulative element count. When row count < 1024 but total array elements > 1024, IndexOutOfBoundsException occurred. Solution: ArrowArrayWriter now calculates elementHandleSafe based on actual element index instead of inheriting parent's handleSafe flag. Added comprehensive test covering multiple arrays, nested arrays, and mixed column types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: ArrowArrayWriter incorrectly used parent row's handleSafe flag (based on row count) for element writers, while element indices are based on cumulative element count. When row count < 1024 but total array elements > 1024, IndexOutOfBoundsException occurred.
Solution: ArrowArrayWriter now calculates elementHandleSafe based on actual element index instead of inheriting parent's handleSafe flag.
Added comprehensive test covering multiple arrays, nested arrays, and mixed column types.
Purpose
Linked issue: close #2164
Brief change log
Tests
API and Format
Documentation