[BP-1.14][FLINK-27399][Connector/Pulsar] [Connector/Pulsar] Change initial consuming position setting logic for better handle the checkpoint.#20565
Conversation
81e7328 to
04dfdd4
Compare
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for cherry-picking this patch. One comment is inline.
Also, I'd like to confirm that you bring the test utils from master to 1.14 for Pulsar Connector tests. Is it right?
|
|
||
| <properties> | ||
| <pulsar.version>2.8.0</pulsar.version> | ||
| <pulsar.version>2.9.1</pulsar.version> |
There was a problem hiding this comment.
How is this version bump necessary?
Basically, we should not bump version in a patch version, especially which can introduce new features.
There was a problem hiding this comment.
We have to use this version bump because the underlying API is introduced on Pulsar 2.9.x.
Yep. The testing tools are introduced for adding transaction support for mocked Pulsar. |
|
@PatrickRen Can you help me review this backport issue? |
…ting logic for better handle the checkpoint. (apache#19972) * Change the initial start cursor and stop cursor to better handle the consuming behaviors. * Create the initial subscription instead seek every time. This should fix the wrong position setting. * Fix the wrong stop cursor, make sure it stops at the correct space * Drop Consumer.seek() for apache/pulsar#16171
04dfdd4 to
f9666b8
Compare
tisonkun
left a comment
There was a problem hiding this comment.
LGTM. Merging...
Anyone can leave a review comment after merge.
This is a backport PR for #19972.