Skip to content

Conversation

@Satvik01000
Copy link
Contributor

Description

Refactored InlineLoanCOBExecutorServiceImpl.getJobParametersMap to extract the repetitive logic for saving custom job parameters.

Changes:

  • Created a private helper method saveCustomJobParameter to handle the creation and saving of JobParameterDTO.

  • Replaced duplicated code blocks in getJobParametersMap with calls to this new helper method.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

@galovics galovics merged commit d043f4c into apache:develop Dec 12, 2025
34 checks passed
@Satvik01000 Satvik01000 deleted the FINERACT-2415-refactor-loan-cob branch December 12, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants