Skip to content

Conversation

@Akshat-Soni02
Copy link

Description

Add the missing READ_FAMILYMEMBERS permission to the m_permission. Not having this permission causes /fineract-provider/api/v1/clients/${clientId}/familymembers to fail.

This PR adds a Liquibase changelog under src/main/resources/db/changelog/tenant/parts/ and includes it from changelog-tenant.xml.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@rhopman
Copy link
Contributor

rhopman commented Nov 12, 2025

Thanks @Akshat-Soni02, looks good to me!

One suggestion: add a preCondition to the changeSet to make it more robust. See 0194_fix_missing_permission.xml for an example.

@Akshat-Soni02
Copy link
Author

@rhopman added the preCondition

@galovics galovics merged commit 9a16a26 into apache:develop Nov 17, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants