Skip to content

FINERACT-2354: Re-aging: DEFAULT BEHAVIOUR - Reverse Replay handling #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 2 commits into from
Nov 13, 2025
Merged

FINERACT-2354: Re-aging: DEFAULT BEHAVIOUR - Reverse Replay handling #5146

adamsaghy merged 2 commits into from
Nov 13, 2025

Conversation

@mariiaKraievska
Copy link
Contributor

@mariiaKraievska mariiaKraievska commented Nov 6, 2025

Description

Added an additional test for the situation where we have reversal of backdated repayment.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling branch from 1789075 to f9abd4d Compare November 10, 2025 14:12
@mariiaKraievska mariiaKraievska marked this pull request as ready for review November 10, 2025 15:48
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling branch from f9abd4d to 2323c39 Compare November 11, 2025 11:37
adamsaghy
adamsaghy reviewed Nov 12, 2025
View reviewed changes
fineract-e2e-tests-runner/src/test/resources/features/LoanReAging.feature Outdated
| Transaction date | Transaction Type | Amount | Principal | Interest | Fees | Penalties | Loan Balance | Reverted | Replayed |
| 01 January 2024 | Disbursement | 100.0 | 0.0 | 0.0 | 0.0 | 0.0 | 100.0 | false | false |
| 01 February 2024 | Repayment | 17.01 | 16.43 | 0.58 | 0.0 | 0.0 | 83.57 | false | false |
| 15 March 2024 | Re-age | 84.28 | 83.57 | 0.71 | 0.0 | 0.0 | 0.0 | false | true |
Copy link
Contributor

@adamsaghy adamsaghy Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this replayed?

Copy link
Contributor Author

@mariiaKraievska mariiaKraievska Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it shouldn't be. Fixed with recent develop changes

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling branch from 2323c39 to 5f100d0 Compare November 13, 2025 08:34
@mariiaKraievska
Copy link
Contributor Author

mariiaKraievska commented Nov 13, 2025

PTAL

@adamsaghy adamsaghy merged commit 0d737b2 into apache:develop Nov 13, 2025
34 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling branch November 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mariiaKraievska @adamsaghy @MarianaDmytrivBinariks