Skip to content

Conversation

@oleksii-novikov-onix
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch 3 times, most recently from 2eff908 to 79e6bed Compare October 22, 2025 11:09
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch from 79e6bed to 97b21f9 Compare October 27, 2025 09:48
@oleksii-novikov-onix oleksii-novikov-onix changed the title FINERACT-2389: Fix grace_on_arrears_ageing overrides handling FINERACT-2389: Fix the handling of nullable field overrides Oct 27, 2025
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch 3 times, most recently from 5f14b03 to c94f141 Compare October 28, 2025 07:28
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch from c94f141 to 5da11ef Compare October 28, 2025 09:18
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review October 28, 2025 09:29
@peter-kovacs-dpc peter-kovacs-dpc force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch from 0877eea to 1d7bf29 Compare October 28, 2025 09:39
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch from 1d7bf29 to 15e4f7b Compare October 28, 2025 13:44
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 8a86759 into apache:develop Oct 29, 2025
33 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2389/grace-on-arrears-ageing-overrides-handling branch October 29, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants