FINERACT-2326: fix delinquency date calculation after pause #5100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
637ac4d to
f0c390e
Compare
galovics
requested changes
Oct 14, 2025
| final long delinquentDays = overdueDays - graceDays; | ||
| if (delinquentDays > 0) { | ||
| calculateDelinquentDays(effectiveDelinquencyList, businessDate, collectionData, delinquentDays); | ||
| Long calculatedDelinquentDays = delinquentDays - pausedDays; |
Contributor
There was a problem hiding this comment.
I'd love to extract this logic into a method that can be reused, otherwise I fear this duplicated (triplicated) logic would be changed in the future only in 1 place, not at the rest of them.
The pausedDays retrieval can also be included here instead and in the extracted method.
If that's done, I think we're good.
Contributor
Author
There was a problem hiding this comment.
Good point! I tried to keep the changes minimal, but a refactor like this certainly makes sense
f0c390e to
fcbe686
Compare
311237b to
c77fe2c
Compare
7d584e3 to
0245ba2
Compare
a2979b5 to
a8ea2bf
Compare
9d961a7 to
26795d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.