Skip to content

Conversation

@budaidev
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

../gradlew cucumber -Pcucumber.tags="@Smoke and not @ignore"
----

==== Report Generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@budaidev I would suggest to add also mention of Allure reporting - it's generated using gradle's allureReport task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an allure section

[source,bash]
----
# Run tests in parallel (adjust thread count based on your system)
../gradlew cucumber --parallel --max-workers=4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@budaidev not sure if we support parallel execution using cucumber
cc @peter-kovacs-dpc @adamsaghy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we are not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I removed it

@budaidev budaidev force-pushed the FINERACT-1724/document-testing branch from f31a984 to 7eb875d Compare September 30, 2025 13:11
@budaidev budaidev marked this pull request as ready for review September 30, 2025 20:41
@adamsaghy adamsaghy merged commit cb7ead2 into apache:develop Oct 1, 2025
33 checks passed
@adamsaghy adamsaghy deleted the FINERACT-1724/document-testing branch October 1, 2025 10:14
@meonkeys
Copy link
Contributor

meonkeys commented Oct 20, 2025

Woah this is awesome work!

One note: a running Apache Fineract instance is not strictly a prerequisite for integration tests because one is started for you with cargo.

Also: Google Chrome is now a prerequisite for oauth2 tests, since fa9c7b9 ... but I don't see mention of oauth2 tests in the docs yet, and requiring a full browser install may be an antipattern?

Also: new tests should use BDD/cucumber, not the old "integration" style, right? Or does it just depend on what's being tested? If it's the former, I'm thinking we should add something about that to these docs, e.g.: "Before writing a new integration test, consider creating a cucumber test."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants