-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-1724: Document integration and e2e testing in fineract #5067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-1724: Document integration and e2e testing in fineract #5067
Conversation
| ../gradlew cucumber -Pcucumber.tags="@Smoke and not @ignore" | ||
| ---- | ||
|
|
||
| ==== Report Generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@budaidev I would suggest to add also mention of Allure reporting - it's generated using gradle's allureReport task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an allure section
| [source,bash] | ||
| ---- | ||
| # Run tests in parallel (adjust thread count based on your system) | ||
| ../gradlew cucumber --parallel --max-workers=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@budaidev not sure if we support parallel execution using cucumber
cc @peter-kovacs-dpc @adamsaghy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we are not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I removed it
f31a984 to
7eb875d
Compare
|
Woah this is awesome work! One note: a running Apache Fineract instance is not strictly a prerequisite for integration tests because one is started for you with cargo. Also: Google Chrome is now a prerequisite for oauth2 tests, since fa9c7b9 ... but I don't see mention of oauth2 tests in the docs yet, and requiring a full browser install may be an antipattern? Also: new tests should use BDD/cucumber, not the old "integration" style, right? Or does it just depend on what's being tested? If it's the former, I'm thinking we should add something about that to these docs, e.g.: "Before writing a new integration test, consider creating a cucumber test." |
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.