FINERACT-2346: Minor sonarqube fixes #4959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galovics
approved these changes
Aug 15, 2025
Contributor
Author
|
@galovics Pls re run the workflow, i have applied the spotless java changes and now giving successfull message on BUILD SUCCESSFUL in 23m 3s If there is any other test i have to run kindly tell me. |
Contributor
Author
|
@galovics Please re run workflow |
Contributor
Author
|
@galovics Requesting you to review again as i have made more changes in files, And i noticed that in workflow rerun it was cancelled midway if any test is failing from my code please tell me. |
Contributor
Author
org.apache.fineract.integrationtests.LoanCatchUpIntegrationTest |
Contributor
Author
|
@galovics Please re run the workflow, Now all workflow should work. |
apply java sptless changes spotless apply Bump actions/checkout from 4.2.2 to 5.0.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11bd719...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> FINERACT-2326: Extract out external dependencies from Client and Group entity FINERACT-2330: Buy-Down fees Accounting for non merchant product FINERACT-2326: Missing user permission for Capitalized Income and Buydown fee
…allow conditionally register beans in `fineract-progressive-loan` module
…eaks repayment schedule and loan status to OVERPAID
…eaks repayment schedule and loan status to OVERPAID - E2E tests Implemented Sonar Fixes
… accounting account interest receivables account. (apache#4876)
…- Reschedule installment (Extend repayment period)
…lment (Extend repayment period)
…nly return the newly created Interest Refund transaction identifiers in the result.
…ter loan approval
…ation with zero value
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@c5195ef...dded088) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Tidy up docs post-1.12.1 release, alongside updates to https://cwiki.apache.org/confluence/display/FINERACT/
7b0b563 to
4e98009
Compare
Contributor
Author
|
rerasising pr with sqash commit |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR introduces refactoring and code quality improvements in specific files to enhance readability, maintainability, and consistency. No changes were made to business logic or API behavior.
Files Changed
custom/acme/loan/starter/src/test/java/com/acme/fineract/loan/starter/AcmeBusinessStepDefinitions.java
fineract-accounting/src/main/java/org/apache/fineract/accounting/closure/api/GLClosuresApiResource.java
fineract-investor/src/main/java/org/apache/fineract/investor/accounting/journalentry/service/InvestorAccountingHelper.java
fineract-investor/src/main/java/org/apache/fineract/investor/api/ExternalAssetOwnersApiResource.java
Key Changes
Refactoring: Improved code structure, readability, and removed redundant code/comments.
API Annotation Cleanup: Simplified and standardized API annotation usage for better documentation consistency.
Constant Extraction: Replaced string literals with constants in parameter usage.
Logic Simplification: Merged nested conditions for clarity.
Motivation
To standardize code style and documentation.
To reduce maintenance overhead by removing repetition and improving clarity.
To prepare the codebase for easier future enhancements.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.