Skip to content

Conversation

@alberto-art3ch
Copy link
Contributor

…p entity

Description

We should move away from injecting any external dependencies in the entity:

accountNumberRequiresAutoGeneration

FINERACT-2326

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/extract-out-external-dependencies-from-client-entity-ccount-number-auto-generation branch 3 times, most recently from af7efc2 to 097d58b Compare August 14, 2025 02:47
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/extract-out-external-dependencies-from-client-entity-ccount-number-auto-generation branch from 097d58b to 5a220b8 Compare August 14, 2025 03:53
@galovics galovics merged commit 125c8b4 into apache:develop Aug 15, 2025
39 checks passed
@galovics galovics deleted the FINERACT-2326/extract-out-external-dependencies-from-client-entity-ccount-number-auto-generation branch August 15, 2025 20:53
@adamsaghy adamsaghy changed the title FINERACT-2326: Extract out external dependencies from Client and Grou… FINERACT-2326: Extract out external dependencies from Client and Group entity Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants