Skip to content

Conversation

@alberto-art3ch
Copy link
Contributor

Description

BuyDown fees accounting is currently configured to support merchant lending where merchant accounting is handling outside Fineract system. Hence the system has been configured to affect the EXPENSE account.

However, for non-merchant products the system should affect the ASSET account.

FINERACT-2330

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2330/buy-down-fees-accounting-for-non-merchant-product branch 2 times, most recently from 4bb19c9 to 8b66637 Compare August 8, 2025 22:52
@alberto-art3ch alberto-art3ch marked this pull request as ready for review August 12, 2025 01:33
@adamsaghy adamsaghy marked this pull request as draft August 13, 2025 12:12
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Testing is missing yet...

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2330/buy-down-fees-accounting-for-non-merchant-product branch from 8b66637 to 8a944fe Compare August 13, 2025 23:15
@alberto-art3ch
Copy link
Contributor Author

LGTM Testing is missing yet...

@adamsaghy done TC added

@alberto-art3ch alberto-art3ch marked this pull request as ready for review August 14, 2025 00:09
@galovics galovics merged commit 6bbc4bd into apache:develop Aug 15, 2025
39 checks passed
@galovics galovics deleted the FINERACT-2330/buy-down-fees-accounting-for-non-merchant-product branch August 15, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants