FINERACT-2326: Charges with Tax group Id ignored #4929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Aug 7, 2025
| @AllArgsConstructor | ||
| @Getter | ||
| @Setter | ||
| public final class TaxGroupData { |
Contributor
There was a problem hiding this comment.
Why to remove Serializable interface?
Contributor
Author
There was a problem hiding this comment.
@adamsaghy For some reason the Serializable was not serializing the attributes like Id and Name, The same happens with the TaxComponentData class
Contributor
There was a problem hiding this comment.
Never heard such thing... Lets connect on this.
Contributor
Author
There was a problem hiding this comment.
Here is an image for this:
Contributor
There was a problem hiding this comment.
I think the issue was with the missing setter/getter/constructor, not the Serializable interface. Would you mind to put it back?
Contributor
Author
There was a problem hiding this comment.
Done! Code updated as It was requested
e223ced to
195910d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue when we are adding a Charge with Tax Group linked and It is not stored due It is not part of request object
FINERACT-2326
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.