Skip to content

FINERACT-2326: Set precision of 6 for the audit fields of the datatab… #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 1 commit into from
Aug 1, 2025
Merged

FINERACT-2326: Set precision of 6 for the audit fields of the datatab… #4901

adamsaghy merged 1 commit into from
Aug 1, 2025

Conversation

@alberto-art3ch
Copy link
Contributor

@alberto-art3ch alberto-art3ch commented Jul 29, 2025 •
edited
Loading

…les (mysql)

Description

Set precision of 6 for the audit fields of the datatables for MySQL database type. This will apply only for new datatables

FINERACT-2326

Screenshot 2025-07-28 at 10 13 38 p m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

adamsaghy
adamsaghy reviewed Jul 30, 2025
View reviewed changes
...ache/fineract/infrastructure/core/serialization/DatatableCommandFromApiJsonDeserializer.java Outdated
case API_FIELD_TYPE_DATE:
return DATE;
case API_FIELD_TYPE_DATETIME:
case API_FIELD_TYPE_DATETIME6:
Copy link
Contributor

@adamsaghy adamsaghy Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need a new type. I just simply want the DATETIME to set precision as 6. No exceptions!

Copy link
Contributor Author

@alberto-art3ch alberto-art3ch Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Code updated

adamsaghy
adamsaghy requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need this... We should just set to use 6 precision for DATETIME, every DATETIME!

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/set-precision-of-6-for-the-audit-fields-of-the-datatables-mysql branch 2 times, most recently from 584bd6b to 47effb4 Compare July 30, 2025 17:57
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/set-precision-of-6-for-the-audit-fields-of-the-datatables-mysql branch from 47effb4 to 1f1abf6 Compare July 31, 2025 15:09
@adamsaghy adamsaghy merged commit bd8b4fe into apache:develop Aug 1, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2326/set-precision-of-6-for-the-audit-fields-of-the-datatables-mysql branch August 1, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alberto-art3ch @adamsaghy