Skip to content

Conversation

@adamsaghy
Copy link
Contributor

@adamsaghy adamsaghy commented Jul 28, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy force-pushed the FINERACT-2118/optional-configuration-for-s3 branch from 15602ce to 35b6ace Compare July 28, 2025 14:23
Copy link
Contributor

@somasorosdpc somasorosdpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy force-pushed the FINERACT-2118/optional-configuration-for-s3 branch from 35b6ace to 761eb0f Compare July 28, 2025 14:45
@adamsaghy adamsaghy force-pushed the FINERACT-2118/optional-configuration-for-s3 branch from 761eb0f to 24a7116 Compare July 28, 2025 15:20
@adamsaghy adamsaghy merged commit 271ac85 into apache:develop Jul 28, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2118/optional-configuration-for-s3 branch July 28, 2025 16:11
@adamsaghy adamsaghy changed the title FINERACT-2118: Make region as optional and remove hardcoded default v… FINERACT-2118: Make region as optional and remove hardcoded default value Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants