Skip to content

FINERACT-2311: Buy Down Fees - External Business Events #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 3 commits into from
Aug 6, 2025
Merged

FINERACT-2311: Buy Down Fees - External Business Events #4893

adamsaghy merged 3 commits into from
Aug 6, 2025

Conversation

@somasorosdpc
Copy link
Contributor

@somasorosdpc somasorosdpc commented Jul 28, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@somasorosdpc somasorosdpc force-pushed the FINERACT-2311/Buy-Down-fees--External-business-events branch 3 times, most recently from ec2b0bd to 2667acb Compare July 30, 2025 07:38
@somasorosdpc somasorosdpc force-pushed the FINERACT-2311/Buy-Down-fees--External-business-events branch 4 times, most recently from 63383d2 to 6c53598 Compare July 31, 2025 09:23
@somasorosdpc somasorosdpc force-pushed the FINERACT-2311/Buy-Down-fees--External-business-events branch from 6c53598 to ba12c68 Compare July 31, 2025 13:35
@magyari-adam
FINERACT-2311: Buy Down fees - External business events
7749812 
- buy down fee reversal fix
- added more listeners for buy down fee amortization on closed loans
@magyari-adam magyari-adam force-pushed the FINERACT-2311/Buy-Down-fees--External-business-events branch from 74b60cf to 7749812 Compare August 1, 2025 14:12
@somasorosdpc somasorosdpc marked this pull request as ready for review August 6, 2025 10:46
adamsaghy
adamsaghy approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 9ed26cb into apache:develop Aug 6, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2311/Buy-Down-fees--External-business-events branch August 6, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy approved these changes

+1 more reviewer

@magyari-adam magyari-adam magyari-adam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@somasorosdpc @magyari-adam @adamsaghy @peter-kovacs-dpc