Skip to content

Conversation

@meonkeys
Copy link
Contributor

@meonkeys meonkeys commented Jul 28, 2025

Description

See FINERACT-2335.

It's so we get this:

$ ls -lh fineract-war/build/distributions/
total 433M
-rw-rw-r-- 1 marie users 422M Jul 28 07:11 apache-fineract-bin-1.12.1.tar.gz
-rw-rw-r-- 1 marie users  11M Jul 28 07:06 apache-fineract-src-1.12.1.tar.gz

instead of this:

$ ls -lh fineract-war/build/distributions/
total 433M
-rw-rw-r-- 1 marie users 422M Jul 28 07:11 apache-fineract-1.12.1-binary.tar.gz
-rw-rw-r-- 1 marie users  11M Jul 28 07:06 apache-fineract-1.12.1-src.tar.gz

and so their contents match their names (so they explode into a directory of the same name as the file, minus .tar.gz)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Release tarballs are currently renamed (without changing the contents): apache-fineract-src-1.12.1.tar.gz becomes apache-fineract-1.12.1-src.tar.gz . The former matches the exploded directory name, the latter does not. The difference is subtle but meaningful... I strongly prefer the former because it's less surprising / more common, and easier to work with from scripts.

There's no functional difference, this should only impact aesthetics.

I did also shorten `binary` to `bin` so release artifact name lengths match.
@meonkeys meonkeys force-pushed the fix-tarball-naming branch from 6fd9767 to e701c30 Compare July 28, 2025 14:05
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meonkeys meonkeys merged commit e090da2 into develop Jul 28, 2025
78 checks passed
@meonkeys meonkeys deleted the fix-tarball-naming branch July 28, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants