FINERACT-2311: Buy Down fees - Reversal of existing transaction #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ea9a1d to
ae7cd79
Compare
somasorosdpc
approved these changes
Jul 30, 2025
adamsaghy
reviewed
Jul 30, 2025
| return LoanTransactionType.CAPITALIZED_INCOME.equals(getTypeOf()) && isNotReversed(); | ||
| } | ||
|
|
||
| public boolean isDefferedIncome() { |
Contributor
Author
There was a problem hiding this comment.
Done! Typo fixed
adamsaghy
reviewed
Jul 30, 2025
| Loan loan = buyDownFeeTransaction.getLoan(); | ||
| BigDecimal totalAmortizationAmount = BigDecimal.ZERO; | ||
|
|
||
| final List<LoanTransactionRelation> loanTransactionRelations = loanTransactionRelationRepository |
Contributor
There was a problem hiding this comment.
We dont need to fetch all the relations and go through on loan transactions (and effectively fetch them) to make this decision. Please write a simply query which returns the required information:
- boolean
- related transaction id
Contributor
Author
There was a problem hiding this comment.
Done! Method updated to return a boolean value
adamsaghy
requested changes
Jul 30, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please take a look on my concerns!
1b8f0be to
aafd96a
Compare
…al of existing transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support reversal of “Buy Down fees” transactions.
Not yet reversed “Buy Down fees” transaction is allowed to be reversed if
Mirror JE entries will be based for reversal entry of that transaction
There is no any not yet reversed “Buy Down fees Adjustment” that belongs to this transactions (transaction relationship)
When “Buy Down fees” transaction is reversed, all already amortized amounts should be corrected in a “Buy Down fees amortization adjustment“ transaction.
Mirror JE entries of “Buy Down fees amortization“.
COB will handle the adjustment transaction
Delete related buy down fee balance
FINERACT-2311
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.