Description

Currently during payment allocation when a repayment or charge-off transaction is made we don't handle it correctly if the current period is already fully paid.

If a repayment transaction is made on a progressive loan that fully pays the outstanding amounts and the preclose recalculation strategy is set to "till rest frequency" we fail to calculate the additional interest that would accrue until the end of the current repayment period.

If a charge-off transaction occurs on a closed period, we must not calculate additional interest on the charge-off transaction, because a charge-off is only supposed cover the total outstanding principal plus interest outstanding till current date.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.