Skip to content

Conversation

@mariiaKraievska
Copy link
Contributor

Description

This PR introduces the functionality to reverse a "Buy Down fees Adjustment" transaction

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2311/buy-down-fees-adjustment-reversal-of-existing-transaction branch from 8ae5de7 to 850f883 Compare July 22, 2025 16:40
@mariiaKraievska mariiaKraievska marked this pull request as ready for review July 25, 2025 10:15
Copy link
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidakovic vidakovic merged commit 45749d3 into apache:develop Jul 25, 2025
39 checks passed
@vidakovic vidakovic deleted the FINERACT-2311/buy-down-fees-adjustment-reversal-of-existing-transaction branch July 25, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants