-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2327: Allow to create Interest Refund transaction manually #4867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vidakovic
merged 2 commits into
apache:develop
from
openMF:FINERACT-2327/allow-to-create-interest-refund-transaction-manually
Jul 23, 2025
Merged
FINERACT-2327: Allow to create Interest Refund transaction manually #4867
vidakovic
merged 2 commits into
apache:develop
from
openMF:FINERACT-2327/allow-to-create-interest-refund-transaction-manually
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ad91d to
8cfbc62
Compare
adamsaghy
reviewed
Jul 21, 2025
...main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jul 21, 2025
.../main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jul 21, 2025
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Jul 21, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly see my review!
8cfbc62 to
0300c10
Compare
Contributor
Author
|
PTAL |
0300c10 to
74b81ee
Compare
d20aba4 to
2467e24
Compare
…reate Interest Refund transaction manually
2467e24 to
cf0289a
Compare
vidakovic
approved these changes
Jul 23, 2025
Contributor
vidakovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the ability to manually create an Interest Refund transaction for Payout Refund or Merchant Issued Refund transactions, if no such Interest Refund exists yet.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.