Skip to content

Conversation

@mariiaKraievska
Copy link
Contributor

Description

Implements the ability to manually create an Interest Refund transaction for Payout Refund or Merchant Issued Refund transactions, if no such Interest Refund exists yet.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch 3 times, most recently from b1ad91d to 8cfbc62 Compare July 21, 2025 11:52
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my review!

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch from 8cfbc62 to 0300c10 Compare July 21, 2025 12:38
@mariiaKraievska
Copy link
Contributor Author

PTAL

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch from 0300c10 to 74b81ee Compare July 22, 2025 06:59
@ruzeynalov ruzeynalov force-pushed the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch 2 times, most recently from d20aba4 to 2467e24 Compare July 22, 2025 14:41
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch from 2467e24 to cf0289a Compare July 23, 2025 06:09
@mariiaKraievska mariiaKraievska marked this pull request as ready for review July 23, 2025 07:49
Copy link
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidakovic vidakovic merged commit 0b53911 into apache:develop Jul 23, 2025
39 checks passed
@vidakovic vidakovic deleted the FINERACT-2327/allow-to-create-interest-refund-transaction-manually branch July 23, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants