Skip to content

Conversation

@budaidev
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@budaidev budaidev force-pushed the FINERACT-2181/fix-interest-calc-non-disbursed-loan branch 4 times, most recently from 1be8f9a to 0d79c59 Compare July 18, 2025 09:22
@budaidev budaidev marked this pull request as ready for review July 18, 2025 12:54
@budaidev budaidev force-pushed the FINERACT-2181/fix-interest-calc-non-disbursed-loan branch from 0d79c59 to 3af675c Compare July 20, 2025 19:35
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
Copy link
Contributor

@budaidev Please take a look on the failing tests cases and please change from FINERACT-2181 to FINERACT-2326 the PR title and commit message!

@adamsaghy adamsaghy force-pushed the FINERACT-2181/fix-interest-calc-non-disbursed-loan branch 2 times, most recently from ec1cec2 to 78e8774 Compare July 31, 2025 07:51
@adamsaghy adamsaghy force-pushed the FINERACT-2181/fix-interest-calc-non-disbursed-loan branch from 78e8774 to 48c669f Compare July 31, 2025 13:30
@adamsaghy adamsaghy merged commit 0762a01 into apache:develop Jul 31, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2181/fix-interest-calc-non-disbursed-loan branch July 31, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants