Skip to content

Conversation

@somasorosdpc
Copy link
Contributor

@somasorosdpc somasorosdpc commented Jul 7, 2025

implement Progressive Loan schedule handling - interest handling
DECLINING BALANCE interest, Same as repayment period, Equal installments

implementing Calculate interest for exact days in partial period flag allowPartialPeriodInterestCalcualtion.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@somasorosdpc somasorosdpc changed the title FINERACT-1968: Progressive Loan schedule handling - interest handling… FINERACT-1968: Progressive Loan schedule handling - interest handling (DECLINING BALANCE interest, Same as repayment period, Equal installments) Jul 7, 2025
@somasorosdpc somasorosdpc force-pushed the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch 4 times, most recently from b00e91e to 28e6955 Compare July 11, 2025 13:37
@somasorosdpc somasorosdpc force-pushed the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch from 28e6955 to 687f719 Compare July 30, 2025 07:59
@somasorosdpc somasorosdpc marked this pull request as ready for review July 31, 2025 07:48
@somasorosdpc somasorosdpc marked this pull request as draft July 31, 2025 08:26
@peter-kovacs-dpc peter-kovacs-dpc force-pushed the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch from 6a9069a to 76dd09f Compare August 1, 2025 16:12
… (DECLINING BALANCE interest, Same as repayment period, Equal installments)
@peter-kovacs-dpc peter-kovacs-dpc force-pushed the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch from 76dd09f to deaaf2c Compare August 1, 2025 16:18
@somasorosdpc somasorosdpc marked this pull request as ready for review August 4, 2025 08:02
.gitignore Outdated
.java-version
.java-version

# AI Development Tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need all of these changes? We can add .claude/ as well then

Copy link
Contributor

@adamsaghy adamsaghy Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peter-kovacs-dpc Seems not relevant... Would you mind to remove?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

… (DECLINING BALANCE interest, Same as repayment period, Equal installments) - E2E tests
@peter-kovacs-dpc peter-kovacs-dpc force-pushed the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch from deaaf2c to dd3d523 Compare August 4, 2025 12:22
@adamsaghy adamsaghy merged commit 9f53440 into apache:develop Aug 5, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-1968/Progressive-Loan-schedule-handling-interest-handling-DECLINING-BALANCE-interest-Same-as-repayment-period-Equal-installments branch August 5, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants