Skip to content

FINERACT-2218: Fix Type Mismatch in Survey Validation Query #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 1 commit into from
Aug 7, 2025
Merged

FINERACT-2218: Fix Type Mismatch in Survey Validation Query #4640

adamsaghy merged 1 commit into from
Aug 7, 2025

Conversation

@Pinchez25
Copy link
Contributor

@Pinchez25 Pinchez25 commented May 5, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch from 6d470bf to eb4d0ee Compare May 5, 2025 11:31
@adamsaghy
Copy link
Contributor

adamsaghy commented Jun 2, 2025

@Pinchez25 The build is failing:

    (see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
  Did you mean 'recurrenceBuilder.append(weekDays.toString().toUpperCase(Locale.ROOT));' or 'recurrenceBuilder.append(weekDays.toString().toUpperCase(Locale.getDefault()));' or 'recurrenceBuilder.append(Ascii.toUpperCase(weekDays.toString()));'?
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/spm/data/ResponseData.java:62: error: [EqualsGetClass] Prefer instanceof to getClass when implementing Object#equals.
    public boolean equals(Object o) {
                   ^

VictorPavfurious
VictorPavfurious reviewed Jun 10, 2025
View reviewed changes
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch 4 times, most recently from 15140c7 to 7f983a6 Compare June 17, 2025 05:58
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch from 7f983a6 to aecc5ec Compare June 18, 2025 04:20
@Pinchez25
Copy link
Contributor Author

Pinchez25 commented Jun 23, 2025

@adamsaghy
How can I find out why these actions are failing. Can I run the tests locally?

@adamsaghy
Copy link
Contributor

adamsaghy commented Jun 23, 2025

@adamsaghy How can I find out why these actions are failing. Can I run the tests locally?

Yes, of course you can run locally integration tests or just 1 particular test!

You can find a how to run integration tests guide here: https://fineract-academy.com/how-to-run-fineract-integration-test-with-intellij-idea.html

org.apache.fineract.integrationtests.SpmServiceIntegrationTest

  Test testCreateSurvey() FAILED

  java.lang.AssertionError: 
  Expecting actual not to be null
      at org.apache.fineract.integrationtests.SpmServiceIntegrationTest.testCreateSurvey(SpmServiceIntegrationTest.java:59)

  Test testCreateSurveyWithInvalidData() FAILED

  java.lang.AssertionError: 
  Expecting code to raise a throwable.
      at org.apache.fineract.integrationtests.SpmServiceIntegrationTest.testCreateSurveyWithInvalidData(SpmServiceIntegrationTest.java:80)

@adamsaghy
Copy link
Contributor

adamsaghy commented Jul 17, 2025

@Pinchez25 What's up here?

@Pinchez25
Copy link
Contributor Author

Pinchez25 commented Jul 21, 2025 •
edited
Loading

@adamsaghy I'll work on it this week

@adamsaghy
Copy link
Contributor

adamsaghy commented Jul 21, 2025 •
edited
Loading

[> @adamsaghy I'll work on it this week

](https://fineract-academy.com/how-to-run-fineract-integration-test-with-intellij-idea-html/)

@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch 2 times, most recently from 3ecc683 to a430fa4 Compare July 23, 2025 07:48
galovics
galovics requested changes Jul 29, 2025
View reviewed changes
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch 2 times, most recently from 9d2573b to 069e7c7 Compare August 4, 2025 11:05
@Pinchez25 Pinchez25 marked this pull request as draft August 4, 2025 11:08
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch from 069e7c7 to 74ded60 Compare August 4, 2025 13:42
@Pinchez25 Pinchez25 marked this pull request as ready for review August 4, 2025 13:44
@Pinchez25 Pinchez25 requested a review from galovics August 4, 2025 13:44
@Pinchez25 Pinchez25 marked this pull request as draft August 5, 2025 13:39
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch 4 times, most recently from 24bc70e to 0206216 Compare August 5, 2025 14:13
@Pinchez25 Pinchez25 force-pushed the fix/survey-creation branch from 0206216 to 4973f4d Compare August 5, 2025 15:42
@Pinchez25 Pinchez25 marked this pull request as ready for review August 5, 2025 17:52
@adamsaghy adamsaghy merged commit 52d3f32 into apache:develop Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VictorPavfurious VictorPavfurious Awaiting requested review from VictorPavfurious

@galovics galovics Awaiting requested review from galovics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pinchez25 @adamsaghy @galovics @VictorPavfurious