Skip to content

Conversation

@VictorPavfurious
Copy link
Contributor

Description

  1. Replace String response API to dto;
  2. Add lombok to dto and clean custom swagger doc from controller;
  3. Change tests response to correct dto;

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy merged commit ac8f62d into apache:develop Mar 19, 2025
10 checks passed
@VictorPavfurious VictorPavfurious deleted the FINERACT-2169/Document_managment_api branch March 28, 2025 12:34
@vidakovic vidakovic changed the title FINERACT-2169: Refactor document management api and update swagger doc; FINERACT-2246: New command processing - Document Management (org.apache.fineract.infrastructure.documentmanagement) May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants