Skip to content

FINERACT-2216: add github project metadata #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 1 commit into from
Mar 19, 2025
Merged

FINERACT-2216: add github project metadata #4464

adamsaghy merged 1 commit into from
Mar 19, 2025

Conversation

@meonkeys
Copy link
Contributor

@meonkeys meonkeys commented Mar 14, 2025 •
edited
Loading

  1. Link to project homepage at https://fineract.apache.org
  2. Add some tags/labels/topics

See also:

Description

See https://issues.apache.org/jira/browse/FINERACT-2216

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

adamsaghy
adamsaghy approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamsaghy
adamsaghy requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach the required "Apache" licence ;)

@meonkeys
Copy link
Contributor Author

meonkeys commented Mar 17, 2025 •
edited
Loading

There's nowhere to add it. The .asf.yaml file is allows us to set a more useful project description, homepage link, and labels. I think that's about it?

See https://github.com/apache/infrastructure-asfyaml/blob/main/asfyaml/feature/github/__init__.py#L57

GitHub derives the project license from the LICENSE_* files. Unfortunately it gets confused because we have two of them, but that's a separate problem we apparently can't solve with .asf.yaml.

Screenshot from 2025-03-17 06-35-49

@adamsaghy
Copy link
Contributor

adamsaghy commented Mar 17, 2025 •
edited
Loading

@meonkeys Okay, but you need to add this file to the exclusion list then:
build.gradle:242

@meonkeys
Copy link
Contributor Author

meonkeys commented Mar 17, 2025

Oh I see! Ok, will do. I'll also sign my commits... I'm trying to get in that habit too

@meonkeys meonkeys force-pushed the add-github-project-metadata branch from 417dd0f to dd77e07 Compare March 17, 2025 17:21
@meonkeys meonkeys force-pushed the add-github-project-metadata branch from dd77e07 to dd52c7e Compare March 17, 2025 17:24
@meonkeys meonkeys requested a review from adamsaghy March 17, 2025 17:25
@IOhacker
Copy link
Contributor

IOhacker commented Mar 18, 2025

LGTM

@adamsaghy adamsaghy merged commit 34cdf4d into apache:develop Mar 19, 2025
10 checks passed
@meonkeys meonkeys deleted the add-github-project-metadata branch March 20, 2025 04:40
@meonkeys
Copy link
Contributor Author

meonkeys commented Mar 20, 2025

Oh cool and it already worked. Looks great. Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy Awaiting requested review from adamsaghy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meonkeys @adamsaghy @IOhacker