FINERACT-2081: Upgrade Spring Batch to 5.1.2 version #3945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jun 21, 2024
| @Autowired | ||
| private PlatformTransactionManager transactionManager; | ||
| @Autowired | ||
| private RemotePartitioningManagerStepBuilderFactory stepBuilderFactory; |
Contributor
Author
There was a problem hiding this comment.
This is not needed more
Contributor
Author
There was a problem hiding this comment.
The factory is deprecated, https://github.com/spring-projects/spring-batch/pull/4582/files
Contributor
There was a problem hiding this comment.
RemotePartitioningManagerStepBuilderFactory is not deprecated. Please dont remove it!
Contributor
Author
There was a problem hiding this comment.
Change reverted
adamsaghy
requested changes
Jun 21, 2024
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly check my review!
5085cc3 to
170f613
Compare
adamsaghy
reviewed
Jun 24, 2024
|
|
||
| @Bean(name = LoanCOBConstant.LOAN_COB_WORKER_STEP) | ||
| public Step loanCOBWorkerStep() { | ||
| return stepBuilderFactory.get("Loan COB worker - Step").inputChannel(inboundRequests).flow(flow()).build(); |
Contributor
There was a problem hiding this comment.
Please revert this change...
170f613 to
fadf482
Compare
fadf482 to
bf64333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to resolve some issues with remote workers, we are upgrading the Spring Batch version to 5.1.2
Release v5.1.2 · spring-projects/spring-batch
FINERACT-2081
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.