FINERACT-2096: Fix duplicate key value exception #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jun 14, 2024
fineract-core/src/main/java/org/apache/fineract/commands/service/CommandSourceService.java
Show resolved
Hide resolved
adamsaghy
requested changes
Jun 14, 2024
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly check my review!
eba07a6 to
4250074
Compare
Contributor
Author
Changes applied please review |
4250074 to
09a7de6
Compare
adamsaghy
reviewed
Jun 14, 2024
| CommandSource initialCommandSource = getInitialCommandSource(wrapper, jsonCommand, maker, idempotencyKey); | ||
| return commandSourceRepository.saveAndFlush(initialCommandSource); | ||
| } catch (JpaSystemException jse) { | ||
| if (jse.getRootCause().getMessage().contains("UNIQUE_PORTFOLIO_COMMAND_SOURCE")) { |
Contributor
There was a problem hiding this comment.
Please use null checks! Root cause and message both can be null!
Contributor
Author
There was a problem hiding this comment.
Done! null checks added
f30692c to
5524ff3
Compare
adamsaghy
reviewed
Jun 17, 2024
| return commandSourceRepository.saveAndFlush(initialCommandSource); | ||
| } catch (JpaSystemException jse) { | ||
| final String message = (jse.getRootCause() != null) ? jse.getRootCause().getMessage() : null; | ||
| if (message != null && message.contains("UNIQUE_PORTFOLIO_COMMAND_SOURCE")) { |
Contributor
There was a problem hiding this comment.
I reckon we need to slightly modify to work with MariaDB and Postgres as well:
message.toLowerCase().contains("unique_portfolio_command_source")
adamsaghy
requested changes
Jun 17, 2024
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly check my review!
5524ff3 to
ad2f7d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix duplicate key value exception to be managed as
IdempotentCommandProcessUnderProcessingExceptionwith HTTP code 425FINERACT-2096
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.