Skip to content

Conversation

@GOODBOY008
Copy link
Member

Purpose of the pull request

Fix Lombok configuration issues by removing unnecessary @EqualsAndHashCode annotation from AnalysisCell class.

What's changed?

  • Removed @EqualsAndHashCode annotation from AnalysisCell class in fesod/src/main/java/org/apache/fesod/sheet/write/metadata/fill/AnalysisCell.java
  • This simplifies the class and addresses Lombok-related concerns

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Copilot AI review requested due to automatic review settings December 4, 2025 05:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the @EqualsAndHashCode Lombok annotation from the AnalysisCell class to address Lombok configuration issues. The class already has manual equals() and hashCode() method implementations, making the annotation redundant.

Key Changes:

  • Removed the @EqualsAndHashCode annotation from the class declaration, eliminating redundancy with the existing manual implementations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GOODBOY008
Copy link
Member Author

@psxjoy @delei PTAL

@psxjoy psxjoy self-requested a review December 4, 2025 09:56
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit 68109d4 into apache:main Dec 4, 2025
9 checks passed
@GOODBOY008 GOODBOY008 deleted the feature/fix-lombok branch December 5, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants