Skip to content

Conversation

@GOODBOY008
Copy link
Member

Description

This PR continues the refactoring effort to replace FastExcel with FesodSheet throughout the codebase, focusing on the examples module's demo package.

Motivation

This refactoring aligns the examples module with the project's rebranding from FastExcel to Fesod, ensuring consistency across the codebase and documentation.

Impact

  • All example code now uses the updated FesodSheet API

@GOODBOY008
Copy link
Member Author

@psxjoy If the unit tests in the Fesod module also need to be updated, I can include those changes in this PR.

@psxjoy
Copy link
Member

psxjoy commented Nov 19, 2025

@psxjoy If the unit tests in the Fesod module also need to be updated, I can include those changes in this PR.

Don't need do that,If all actions passed,I will merge.

没必要,所有的 action 都通过了,我就可以合并。这是个长期的改动;)

@psxjoy psxjoy self-requested a review November 19, 2025 10:53
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@psxjoy psxjoy merged commit 2a945c0 into apache:main Nov 19, 2025
12 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR continues the refactoring effort to replace FastExcel with FesodSheet throughout the examples module, ensuring consistency with the project's rebranding from FastExcel to Fesod.

Key Changes

  • Replaced all FastExcel imports with FesodSheet imports across 8 test files
  • Updated all method calls from FastExcel.* to FesodSheet.* throughout the examples
  • Renamed FastExcelApplication class to FesodApplication to align with the new branding
  • Updated English comments to reference "Fesod" instead of "FastExcel" where applicable

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
WriteWithColorTest.java Updated import and write method call to use FesodSheet
WriteTest.java Comprehensive replacement of FastExcel with FesodSheet across multiple test methods including write, merge, fill, and style operations
EscapeHexCellWriteHandlerTest.java Updated all test methods to use FesodSheet for writing various Excel formats (xlsx, xls, csv)
WebTest.java Updated imports, method calls, and English comments to reference Fesod/FesodSheet
FesodApplication.java Renamed class from FastExcelApplication to FesodApplication
ReadTest.java Updated imports, read method calls, and documentation comments to use FesodSheet and reference Fesod
WriteTest.java (rare package) Updated import and write operations to use FesodSheet
FillTest.java Updated import and fill operations to use FesodSheet

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.sheet("模板")
.doWrite(data());

// 方法2: 使用FastExcel的方式完全自己写 不太推荐 尽量使用已有策略
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment still references "FastExcel" but should be updated to "Fesod" or "FesodSheet" for consistency with the refactoring. The comment should read: "方法2: 使用Fesod的方式完全自己写 不太推荐 尽量使用已有策略" or "方法2: 使用FesodSheet的方式完全自己写 不太推荐 尽量使用已有策略"

Suggested change
// 方法2: 使用FastExcel的方式完全自己写 不太推荐 尽量使用已有策略
// 方法2: 使用FesodSheet的方式完全自己写 不太推荐 尽量使用已有策略

Copilot uses AI. Check for mistakes.
@delei
Copy link
Member

delei commented Nov 20, 2025

If the unit tests in the Fesod module also need to be updated, I can include those changes in this PR.

Hi, @GOODBOY008
Thanks, the unit tests in the Fesod module also need to be updated. This could be a long-term process. Please feel free to submit a PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants