-
Notifications
You must be signed in to change notification settings - Fork 469
refactor: Replace FastExcel with FesodSheet in examples module #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@psxjoy If the unit tests in the Fesod module also need to be updated, I can include those changes in this PR. |
Don't need do that,If all actions passed,I will merge. 没必要,所有的 action 都通过了,我就可以合并。这是个长期的改动;) |
psxjoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR continues the refactoring effort to replace FastExcel with FesodSheet throughout the examples module, ensuring consistency with the project's rebranding from FastExcel to Fesod.
Key Changes
- Replaced all
FastExcelimports withFesodSheetimports across 8 test files - Updated all method calls from
FastExcel.*toFesodSheet.*throughout the examples - Renamed
FastExcelApplicationclass toFesodApplicationto align with the new branding - Updated English comments to reference "Fesod" instead of "FastExcel" where applicable
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WriteWithColorTest.java | Updated import and write method call to use FesodSheet |
| WriteTest.java | Comprehensive replacement of FastExcel with FesodSheet across multiple test methods including write, merge, fill, and style operations |
| EscapeHexCellWriteHandlerTest.java | Updated all test methods to use FesodSheet for writing various Excel formats (xlsx, xls, csv) |
| WebTest.java | Updated imports, method calls, and English comments to reference Fesod/FesodSheet |
| FesodApplication.java | Renamed class from FastExcelApplication to FesodApplication |
| ReadTest.java | Updated imports, read method calls, and documentation comments to use FesodSheet and reference Fesod |
| WriteTest.java (rare package) | Updated import and write operations to use FesodSheet |
| FillTest.java | Updated import and fill operations to use FesodSheet |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .sheet("模板") | ||
| .doWrite(data()); | ||
|
|
||
| // 方法2: 使用FastExcel的方式完全自己写 不太推荐 尽量使用已有策略 |
Copilot
AI
Nov 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment still references "FastExcel" but should be updated to "Fesod" or "FesodSheet" for consistency with the refactoring. The comment should read: "方法2: 使用Fesod的方式完全自己写 不太推荐 尽量使用已有策略" or "方法2: 使用FesodSheet的方式完全自己写 不太推荐 尽量使用已有策略"
| // 方法2: 使用FastExcel的方式完全自己写 不太推荐 尽量使用已有策略 | |
| // 方法2: 使用FesodSheet的方式完全自己写 不太推荐 尽量使用已有策略 |
Hi, @GOODBOY008 |
Description
This PR continues the refactoring effort to replace
FastExcelwithFesodSheetthroughout the codebase, focusing on the examples module's demo package.Motivation
This refactoring aligns the examples module with the project's rebranding from FastExcel to Fesod, ensuring consistency across the codebase and documentation.
Impact
FesodSheetAPI