fix: fixed NPE exception in the WriteSheetWorkbookWriteHandler class #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullPointerException (NPE) in the WriteSheetWorkbookWriteHandler class that occurs when dealing with sheet operations. The fix ensures proper handling of null values in sheet number processing and guarantees that sheetNo is properly set for writeSheetHolder instances.
- Added null filtering in the stream processing to prevent NPE when sorting sheet numbers
- Enhanced sheet initialization to set sheetNo when it's null but the sheet exists
- Added comprehensive test coverage for sheet creation using sheet names
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WriteSheetWorkbookWriteHandler.java | Added null filtering in stream processing to prevent NPE during sheet sorting |
| WriteContextImpl.java | Enhanced initSheet method to set sheetNo when null but sheet exists |
| WriteSheetTest.java | Added new test method to verify sheet creation with sheet names works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alaahong
reviewed
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Close #564
What's changed?
Checklist