Skip to content

Conversation

@delei
Copy link
Member

@delei delei commented Aug 9, 2025

Purpose of the pull request

Related issue: #443

Proofread Result

  • No obvious typos
  • No obvious markdown syntax errors
  • Optimise descriptive terms in certain sections
  • Optimise contribution guidelines

@delei delei marked this pull request as ready for review August 9, 2025 08:25
@delei delei requested a review from psxjoy August 9, 2025 08:25
| order | Integer.MAX_VALUE | 优先级高于`value`,会根据`order`的顺序来匹配实体和excel中数据的顺序 |
| index | -1 | 优先级高于`value``order`,会根据`index`直接指定到excel中具体的哪一列 |
| converter | 自动选择 | 指定当前字段用什么转换器,默认会自动选择。读的情况下只要实现`cn.idev.excel.converters.Converter#convertToJavaData(com.idev.excel.converters.ReadConverterContext<?>)` 方法即可 |
| format || 格式化字符串 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个描述可能有歧义?一个是这里本来指的时间日期格式化专属,格式化字符串容易误导,使得读者以为是String.format之类的效果,另一个该属性已被标记为Deprecated,且似乎当前不起作用?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit c1f2b88 into apache:main Aug 9, 2025
5 checks passed
@delei delei deleted the document-1 branch August 9, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants