fix: fix hex impacting on xls and csv #470
Merged
+383
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add SXSSFCell checking, skip other cell 2. recreate escapeHex method for performance tuning 3. create relative unit test close: #364
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the EscapeHexCellWriteHandler to improve performance and fix type checking issues that affected XLS and CSV file formats. The changes focus on preventing POI from automatically decoding hex-encoded strings in x[0-9A-Fa-f]{4} format by escaping them appropriately.
- Performance optimization through custom hex validation using lookup tables instead of regex
- Type checking fix to only process SXSSFCell instances (XLSX format)
- Comprehensive test coverage for various file formats and edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| EscapeHexCellWriteHandler.java | Replaces regex-based hex processing with optimized manual parsing and adds SXSSFCell type checking |
| EscapeHexCellWriteHandlerTest.java | Adds comprehensive unit tests covering multiple file formats, edge cases, and validation scenarios |
fastexcel/src/main/java/cn/idev/excel/write/handler/EscapeHexCellWriteHandler.java
Show resolved
Hide resolved
fastexcel/src/main/java/cn/idev/excel/write/handler/EscapeHexCellWriteHandler.java
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/EscapeHexCellWriteHandlerTest.java
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/EscapeHexCellWriteHandlerTest.java
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/EscapeHexCellWriteHandlerTest.java
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/EscapeHexCellWriteHandlerTest.java
Show resolved
Hide resolved
Member
Author
|
As I understand, the expected result is not additional prefix "_x005F" and display String well, so no change on given test, resolve all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #364
What's changed?
fastexcel/src/main/java/cn/idev/excel/write/handler/EscapeHexCellWriteHandler.java
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/EscapeHexCellWriteHandlerTest.java
Checklist