refactor: optimize the StyleUtil code #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaahong
reviewed
Aug 3, 2025
Member
alaahong
left a comment
There was a problem hiding this comment.
Seems not mandatory to create a new Class with new Method?
e.g. inline usage is enough
Optional.ofNullable(writeCellStyle.getHidden())
.ifPresent(cellStyle::setHidden);
And meanwhile, even for new Utils, please also provide unit test at same time.
Member
Author
|
We can delete the new utility classes and use internal private methods. |
Member
|
Member
|
All CI fails |
Member
Author
|
fix ci |
Member
Author
|
What else needs to be done |
alaahong
requested changes
Aug 5, 2025
Member
alaahong
left a comment
There was a problem hiding this comment.
why involve new version declaration
psxjoy
approved these changes
Aug 7, 2025
Member
psxjoy
left a comment
There was a problem hiding this comment.
LGTM
If no one has other questions, this PR will merge in 24h.
tisonkun
approved these changes
Aug 11, 2025
Member
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for your contribution!
Merging ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#465
What's changed?
Checklist