chore: update pom.xml for improved formatting and add JDK 8+ profile #432
Conversation
pom.xml
Outdated
| <jdk>[9,)</jdk> | ||
| </activation> | ||
| <properties> | ||
| <jdk.module.addopens> |
There was a problem hiding this comment.
Interesting. I don't find reference to this property. Is it documented somewhere? I wonder its semantic and how it works.
There was a problem hiding this comment.
Interesting. I don't find reference to this property. Is it documented somewhere? I wonder its semantic and how it works.
Check this url:https://maven.apache.org/guides/introduction/introduction-to-profiles.html#JDK
There was a problem hiding this comment.
I refer
jdk.module.addopens.
I didn't correct that part when I submitted it. It wasn't a feature of any kind, just a placeholder string, which has now been corrected.
tisonkun
left a comment
There was a problem hiding this comment.
To verify this change works and prevent regression, we'd better merge https://github.com/fast-excel/fastexcel/blob/c82e99998d9811b0c727a4d4ce3e46370f6efd9f/.github/workflows/ci.yml#L57-L62.
done |
alaahong
left a comment
There was a problem hiding this comment.
please verify with test execution then check below report
fastexcel-test/target/site/jacoco-aggregate/index.html
Co-authored-by: tison <wander4096@gmail.com>
Co-authored-by: tison <wander4096@gmail.com>
|
Hi, @psxjoy <executions>
<execution>
<id>spotless-check</id>
<goals>
<goal>check</goal>
</goals>
<phase>compile</phase>
</execution>
</executions>Just for reference, would it be helpful to us as well? https://github.com/apache/iotdb/blob/master/pom.xml#L1542-L1569 |
Purpose of the pull request
#414
What's changed?
support jdk8 and jdk8+
mvn install.Checklist