Skip to content

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Jul 19, 2025

Purpose of the pull request

  1. add argLine and UTF-8 encoding to avoid Chinese wording exception while mixed jacoco and maven-surefire
  2. add code coverage report in test phase by jacoco
    before change:
    No coverage report in build result
    post change:
    since mvn clean test , the report will be generated as aggregated version in test module
    fastexcel-test/target/site/jacoco-aggregate/index.html
image

BTW, there is a gap as current project test scope only covered test package as cn/idev/excel/test/core
As previous discussion in PR #390 & #392 , the project won't trigger all test case in CI with package demo,temp,util , so the actual coverage might be greater than above ratio of screenshot.

The coverage ratio looks good within IDE as below
image

image

What's changed?

pom.xml
fastexcel-test/pom.xml

Checklist

  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

1. enable test phase by default via set maven.test.skip=false
2. add code coverage report in test phase by jacoco
1. add code coverage report in test phase by jacoco
…rage_report_via_jacoco

# Conflicts:
#	pom.xml
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit af243a7 into apache:main Jul 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants