fix: Fix style test #371
Merged
fix: Fix style test #371
+61
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. remove the case no relationship with FastExcel 2. remove no test case 3. Provide runnable case for style
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the StyleTest class by removing outdated test cases and providing a runnable test case for verifying Excel style formats.
- Removed tests unrelated to the style functionality (e.g., FastExcel and old POI tests).
- Reworked tests to use assertions on cell data and format instead of print statements.
- Updated file paths to reference test resources and refined the isDate method to return a boolean.
Comments suppressed due to low confidence (2)
fastexcel-test/src/test/java/cn/idev/excel/test/temp/StyleTest.java:33
- [nitpick] Method name 'poi07Test' is ambiguous and does not clearly convey the purpose of the test. Consider renaming it to something like 'testExcel2007StyleFormats' for better clarity.
public void poi07Test() throws Exception {
fastexcel-test/src/test/java/cn/idev/excel/test/temp/StyleTest.java:58
- [nitpick] The method name 'poi03Test' does not provide clear insight into what styling behavior is being validated. Renaming it to something more descriptive, such as 'testExcel2003StyleFormats', could improve readability.
public void poi03Test() throws Exception {
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change
Post the change
