Skip to content

feat: add ignoreHiddenSheet parameter #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psxjoy merged 7 commits into from
May 29, 2025
Merged

feat: add ignoreHiddenSheet parameter #354

psxjoy merged 7 commits into from
May 29, 2025

Conversation

@delei
Copy link
Member

@delei delei commented May 9, 2025 •
edited
Loading

PR for #349

What's changed?

  • Add the ignoreHiddenSheet parameter for read,default value is false.if set to true, the data of the hidden sheet will not be read
  • Add sheetHidden and sheetVeryHidden field in ReadSheet Class

Checklist

  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

delei added 5 commits May 3, 2025 19:19
@delei
feat: add sheet hidden state properties
bfb997a
@delei
feat: add ignoreHiddenSheet parameter
8ab1ef6
@delei
test: add unit tests for ignoreHiddenSheet parameter
4484821
@delei
fix: update BofRecordHandler & HiddenSheetsTest
24dcbcd
@delei
fix: update sheetList size
320c76f 
- Add functionality to filter out hidden sheets when reading workbook
- Implement ignoreHiddenSheet option in XlsReadWorkbookHolder
- Update getSheets() method to apply hidden sheet filtering based on option
@delei delei requested review from jipengfei-jpf and psxjoy as code owners May 9, 2025 11:07
@delei delei changed the title [Feature]add ignoreHiddenSheet paramete [Feature]add ignoreHiddenSheet parameter May 11, 2025
psxjoy
psxjoy reviewed May 13, 2025
View reviewed changes
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy added this to the 1.3.0 milestone May 13, 2025
@psxjoy psxjoy added the PR: development completed Development completed, waiting for release label May 13, 2025
@psxjoy
Copy link
Member

psxjoy commented May 13, 2025

Hi, @delei .I noticed you closed the same PR before,what's difference between those two pr?

Hi，我看你之前 close 了一个同样的PR，这两个PR有什么不同吗？

@delei
Copy link
Member Author

delei commented May 13, 2025 •
edited
Loading

😅我的问题，我错误的还原了我自己仓库fork的分支，所以不得不重新推送了这个PR。内容是一样的。

@delei
Copy link
Member Author

delei commented May 28, 2025

  • IMO,in ReadSheet class,it is recommended to keep this 'sheetVeryHidden' attribute, which is consistent with the POI and easy for users to use for special cases
  • BRB,for sheetVeryHidden attribute,i will improve the test case

@psxjoy psxjoy merged commit 1088d68 into apache:main May 29, 2025
4 checks passed
@delei delei deleted the feature/ignoreHiddenSheet-parameter branch May 29, 2025 09:59
@delei delei changed the title [Feature]add ignoreHiddenSheet parameter feat: add ignoreHiddenSheet parameter Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psxjoy psxjoy psxjoy left review comments

@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf

Assignees

No one assigned

Labels

PR: development completed Development completed, waiting for release

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@delei @psxjoy