Skip to content

fix: fix poi write #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psxjoy merged 2 commits into from
May 7, 2025
Merged

fix: fix poi write #348

psxjoy merged 2 commits into from
May 7, 2025
+41 −78

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Apr 30, 2025 •
edited
Loading

  1. Format as current standards
  2. Replace invalid file
  3. Fix resource holding issue
  4. Remove useless case

Before:
image

After:
image

alaahong added 2 commits April 30, 2025 21:04
@alaahong
fix: fix poi write
c20f75f 
1. Format as current standards
2. Replace invalid file
3. Fix resource holding issue
@alaahong
fix: fix poi write
af3ff4d 
1. Format as current standards
2. Replace invalid file
3. Fix resource holding issue
4. Remove useless case
@psxjoy psxjoy added the pending This problem needs to be confirmed label May 6, 2025
@psxjoy
Copy link
Member

psxjoy commented May 7, 2025

LGTM

@psxjoy psxjoy merged commit 4f6d154 into apache:main May 7, 2025
4 checks passed
@alaahong alaahong mentioned this pull request Jul 19, 2025
Open
2 tasks
@delei delei added this to the 1.3.0 milestone Jul 30, 2025
@delei delei removed the pending This problem needs to be confirmed label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf

@psxjoy psxjoy Awaiting requested review from psxjoy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alaahong @psxjoy @delei