Skip to content

Conversation

@alaahong
Copy link
Member

Revise the incorrect resources and redesign the encryption case.

Before Change
image
image

Post Change
image
image

Revise the incorrect resources and redesign the encryption case
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

@alaahong
Copy link
Member Author

alaahong commented Mar 31, 2025

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

Thanks for your following, but where is the code style guidelines?

image

@psxjoy
Copy link
Member

psxjoy commented Mar 31, 2025

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?
Hi,我们已经更新了codestyle,能否更新一下代码,确保符合项目的代码规范呢?

Thanks for your following, but where is the code style guidelines?

image

Sorry for not pointing the code-style file:https://github.com/fast-excel/fastexcel/tree/main/style/codestyle

just format the code as suggested style
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit c657b44 into apache:main Mar 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants