Skip to content

Feature/fix image write issue #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psxjoy merged 4 commits into from
Mar 31, 2025
Merged

Feature/fix image write issue #297

psxjoy merged 4 commits into from
Mar 31, 2025
+4 −2

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Mar 29, 2025

Update not found resource and suggest file type for another solution
Before Change:
image

image

Post Change:
image

alaahong added 3 commits March 30, 2025 00:41
@alaahong
fix: imageWrite issue
a2072ee 
Update not found resource and suggest file type for another solution
@alaahong
fix: imageWrite issue
607e91c 
rollback useless change
@alaahong
fix: imageWrite issue
e8ff4a8 
Update not found resource and suggest file type for another solution
psxjoy
psxjoy requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi，我们已经更新了codestyle，能否更新一下代码，确保符合项目的代码规范呢？

@alaahong
Copy link
Member Author

alaahong commented Mar 31, 2025

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?

Hi，我们已经更新了codestyle，能否更新一下代码，确保符合项目的代码规范呢？

Thanks for your following, please point out the code style guidelines?
Otherwise, how about to export one IDE setting to align the coding format?

image

@psxjoy
Copy link
Member

psxjoy commented Mar 31, 2025

Hi, we’ve revised the code style guidelines. Would you mind updating your code to align with the project’s current standards?
Hi，我们已经更新了codestyle，能否更新一下代码，确保符合项目的代码规范呢？

Thanks for your following, please point out the code style guidelines? Otherwise, how about to export one IDE setting to align the coding format?

image

  1. https://www.jetbrains.com/help/idea/settings-code-style-xml.html
  2. https://github.com/fast-excel/fastexcel/tree/main/style/codestyle

@alaahong
refactor: imageWrite issue
89b7386 
just format the code as suggested style
psxjoy
psxjoy approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy merged commit 6d11dcb into apache:main Mar 31, 2025
4 checks passed
@alaahong alaahong mentioned this pull request Jul 19, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psxjoy psxjoy psxjoy approved these changes

@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alaahong @psxjoy