fix: maven properties and module exception for reflection #284
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. change java version as default maven and spring format As no declare jdk.version in whole project, so remove and add new properties <java.version>1.8</java.version> <maven.compiler.target>1.8</maven.compiler.target> <maven.compiler.source>1.8</maven.compiler.source> reference: https://www.baeldung.com/maven-java-version 2. fix the issue while working above java 8+ as java module mechanism limited Add --add-opens for specific package into maven-surefire-plugin <configuration> <argLine> --add-opens java.base/sun.reflect.annotation=ALL-UNNAMED </argLine> </configuration> reference: --add-opens module/package=target-module(,target-module)* Updates module to open package to target-module, regardless of module declaration. https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html
just comment the add-opens for ci verification
find out same behavior in .github action configuration, so just add as comment
Member
|
LGTM |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As no usage of
jdk.versionin whole project, so remove and add new properties as traditional formatreference:
#https://www.baeldung.com/maven-java-version
Add --add-opens for specific package into maven-surefire-plugin
e.g.
perform the unit test including reflection under java 21
mvn -Dtest=CacheDataTest test -D maven.test.skip=falseBefore the change:
After the change:
reference:
--add-opens module/package=target-module(,target-module)* Updates module to open package to target-module, regardless of module declaration.
#https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html