Skip to content

fix: 填充时日期格式丢失问题 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psxjoy merged 5 commits into from
Mar 20, 2025
Merged

fix: 填充时日期格式丢失问题 #273

psxjoy merged 5 commits into from
Mar 20, 2025

Conversation

@waterisblue
Copy link
Contributor

@waterisblue waterisblue commented Mar 19, 2025

测试代码如下：

@Setter
@Getter
static class FillData {
    private String name;
    private double number;
    private Date date;
    private LocalDate date2;
}
@Test
public void templateWriteFix() {
    String templateFileName = TestFileUtil.getPath() + "demo" + File.separator + "annotation.xlsx";
    String fileName = TestFileUtil.getPath() + "templateWrite" + System.currentTimeMillis() + ".xlsx";
    
    List<FillData> list = ListUtils.newArrayList();
    for (int i = 0; i < 10; i++) {
        FillData fillData = new FillData();
        list.add(fillData);
        fillData.setName("张三");
        fillData.setNumber(5.21111);
        fillData.setDate(new Date());
        fillData.setDate2(LocalDate.now());
    }

    EasyExcel.write(fileName, FillData.class).withTemplate(templateFileName).sheet().doFill(list);
}

#228

psxjoy
psxjoy requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit-test code cases in test module.

@waterisblue
Copy link
Contributor Author

waterisblue commented Mar 19, 2025

When the date cell format is set:
image
Output:
image
When the date cell format is default:
image
Output:
image

@waterisblue waterisblue requested a review from psxjoy March 19, 2025 09:15
@721806280
Copy link
Contributor

721806280 commented Mar 19, 2025

Please make a reasonable assessment as to whether the location of the correction is more appropriate here.
#228 (comment)

@psxjoy
Copy link
Member

psxjoy commented Mar 19, 2025

Please make a reasonable assessment as to whether the location of the correction is more appropriate here. #228 (comment)

Yes. IMO, the changes you suggested are more impactful. Maybe @waterisblue can clarify whether they plan to implement these corrections or if there are advantages to sticking with the original changes.

@waterisblue
Copy link
Contributor Author

waterisblue commented Mar 20, 2025

Yes, this solution has minor impact on the project and can address #228 , but IMO:

  1. Modifying the format of a specific type in the doFill method may be somewhat inconsistent with the programming standard. I believe it is more appropriate to modify the styles in the createCellStyle method.
  2. Discarding type checks and directly calling DateUtils.isADateFormat may affect performance, maybe no fast, of course, this requires more testing.
    @721806280 @psxjoy

@psxjoy
Copy link
Member

psxjoy commented Mar 20, 2025

Both changes work fine. I’ll merge them into master temporarily, and I’ll check the performance details when I have time.
我觉得两个改动都可以。暂时合并到master，性能方面我找时间看下。

@psxjoy psxjoy merged commit 057d178 into apache:main Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psxjoy psxjoy psxjoy approved these changes

@Chat2DB-Pro Chat2DB-Pro Awaiting requested review from Chat2DB-Pro

@jipengfei-jpf jipengfei-jpf Awaiting requested review from jipengfei-jpf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waterisblue @721806280 @psxjoy