Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Mar 26, 2023

Fixes #3526

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Optimize SubStreamHandler

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

mytang0 and others added 30 commits March 3, 2023 14:51
[ISSUE apache#3312]Modify ClientConfiguration class attributes public to private
[ISSUE apache#3317]Modify kafka module ClientConfiguration class attributes public to private
Added null pointer exception.
fixed Null pointer exception error.
* [ISSUE apache#3267] Refactor RequestContext

* polish code
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
Comment on lines +25 to +29
@Slf4j
public abstract class ThreadWrapper implements Runnable {

private final AtomicBoolean started = new AtomicBoolean(false);
protected Thread thread;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides its usage in SubStreamHandler, could ThreadWrapper be utilized in other classes as well?

ThreadWrapper appears to streamline synchronization for SubStreamHandler, eliminating the need for using a latch. However, the synchronization mechanism using latch in SubStreamHandler itself isn't overly complex. Hence, I'm curious whether introducing the additional complexity of ThreadWrapper for synchronization would address additional problems.

@github-actions github-actions bot removed the Stale label Apr 23, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize SubStreamHandler