-
Notifications
You must be signed in to change notification settings - Fork 641
[ISSUE #3526] Optimize SubStreamHandler #3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[ISSUE apache#3290]Refactor ConsumerManager
[ISSUE apache#3312]Modify ClientConfiguration class attributes public to private
[ISSUE apache#3317]Modify kafka module ClientConfiguration class attributes public to private
Added null pointer exception.
fixed Null pointer exception error.
…es public to private
* [ISSUE apache#3267] Refactor RequestContext * polish code
split storage and connectors
[ISSUE apache#3536] remove connector module
Update README.md
transfer dashboard
transfer project
transfer docs to eventmesh-site
transfer catalog from parent
transfer docs
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
| @Slf4j | ||
| public abstract class ThreadWrapper implements Runnable { | ||
|
|
||
| private final AtomicBoolean started = new AtomicBoolean(false); | ||
| protected Thread thread; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides its usage in SubStreamHandler, could ThreadWrapper be utilized in other classes as well?
ThreadWrapper appears to streamline synchronization for SubStreamHandler, eliminating the need for using a latch. However, the synchronization mechanism using latch in SubStreamHandler itself isn't overly complex. Hence, I'm curious whether introducing the additional complexity of ThreadWrapper for synchronization would address additional problems.
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3526
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Optimize SubStreamHandler
Documentation