fix(visualmap): add textShadowColor, make text shadow work on visualMap. close #14440#16679
Merged
pissang merged 4 commits intoapache:masterfrom Mar 17, 2022
Merged
fix(visualmap): add textShadowColor, make text shadow work on visualMap. close #14440#16679pissang merged 4 commits intoapache:masterfrom
pissang merged 4 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
plainheart
reviewed
Mar 14, 2022
Ovilia
requested changes
Mar 14, 2022
plainheart
reviewed
Mar 14, 2022
Member
There was a problem hiding this comment.
One more question,
Should we also apply the text style on handleLabel and indicatorLabel?
Contributor
Author
|
@plainheart Your editing is great, more smarter. |
Contributor
@fuchunhui So are we planning to add this in this PR as @plainheart suggested? |
pissang
approved these changes
Mar 15, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix a bug that some text styles are not working on
visualMap.Fixed issues
Details
visualMap-continuous
visualMap-piecewise
Misc
Related test cases or examples to use the new APIs
test/visualMap-continuous.htmltest/visualMap-pieces.htmlOthers
Merging options
Other information