Skip to content

fix(labelLine): update labelLine ignore#16542

Merged
pissang merged 3 commits intoapache:masterfrom
susiwen8:fix-16539
Mar 24, 2022
Merged

fix(labelLine): update labelLine ignore#16542
pissang merged 3 commits intoapache:masterfrom
susiwen8:fix-16539

Conversation

@susiwen8
Copy link
Copy Markdown
Contributor

@susiwen8 susiwen8 commented Feb 18, 2022 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

It should update ignore

Fixed issues

Details

Before: What was the problem?

Kapture 2022-02-19 at 00 11 55

After: How is it fixed in this PR?

Kapture 2022-02-19 at 00 09 51

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

pie-label.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Feb 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Mar 24, 2022

Sorry for the late review.

The ignore property of label and labelLine is updated in

echarts/src/label/labelStyle.ts

Line 250 in ad3a07a

stateObj.ignore = !stateShow;

echarts/src/label/labelGuideHelper.ts

Line 623 in ad3a07a

stateObj.ignore = true;

Especially the labelLine, it has complex logic to determine if it can be shown when label is not shown. But for some reason it fails when switching from show to hide in the emphasis state.

@susiwen8
Copy link
Copy Markdown
Contributor Author

susiwen8 commented Mar 24, 2022

@pissang Thanks for the pointer

pissang
pissang reviewed Mar 24, 2022
View reviewed changes
@pissang pissang added this to the 5.3.2 milestone Mar 24, 2022
@susiwen8 susiwen8 requested a review from pissang March 24, 2022 14:29
@pissang pissang merged commit 6c721de into apache:master Mar 24, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Mar 24, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the fix-16539 branch March 24, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang pissang approved these changes

@plainheart plainheart Awaiting requested review from plainheart

Assignees

No one assigned

Labels

PR: author is committer size/S

Projects

None yet

Milestone

5.3.2

Development

Successfully merging this pull request may close these issues.

[Bug] LabelLine doesn't hide

2 participants

@susiwen8 @pissang