fix(toolbox): only change title of requested feature. closes #12162#12168
Merged
pissang merged 1 commit intoapache:masterfrom Feb 19, 2020
Merged
fix(toolbox): only change title of requested feature. closes #12162#12168pissang merged 1 commit intoapache:masterfrom
pissang merged 1 commit intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
pissang
approved these changes
Feb 19, 2020
Contributor
|
Nice fix! Thanks! |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Author
|
May I know why this was not included in 4.7.0 release? |
|
@nsmgr8 The 4.8.0 has been resolved.🐛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the toolbox title issue described in #12162
Fixed issues
Details
Before: What was the problem?
After toggling magicType icons, titles in other features in toolbox become
[object Object]. This is becaues the event fired a new title change and it was overwriting all features.After: How is it fixed in this PR?
The event also sends which feature to change the title.
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information